search

mattwebbio / orbital-sync

Synchronize multiple Pi-hole instances
http://orbitalsync.com
MIT License
670 stars 21 forks source link

Pihole V6 #190

Open modem7 opened 1 year ago

modem7 commented 1 year ago

What feature would you like added?

PiHole v6 has just been announced at the start of the month with quite a few changes, including the API and consolidated settings files as two notable (probably breaking) changes.

https://pi-hole.net/blog/2023/10/09/pi-hole-v6-beta-testing/

https://deploy-preview-338--pihole-docs.netlify.app/api/

May be worthwhile to have a look in case you haven't and use this issue as a staging ground to prepare or any questions that may be raised.

FurkanVG commented 3 months ago

How is the progress looking for V6?

timtjtim commented 3 months ago

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.

In fact, given the move away from PHP to a new REST API, this project may become even simpler!

I'm planning to do some testing on this project soon :)

timtjtim commented 3 months ago

Putting my comments on this discussion to avoid spamming notifications

https://github.com/mattwebbio/orbital-sync/discussions/391

timtjtim commented 2 months ago

@mattwebbio It would be good to add a development-v6 branch we can use as a target I think.

mattwebbio commented 2 months ago

@timtjtim Done! https://github.com/mattwebbio/orbital-sync/tree/development-v6

Also: thanks for taking the time to look at this. I'm in the process of moving, so my time is (temporarily) extremely limited. It's a huge help :)

laitco commented 2 months ago

Gravity sync has been archived - given the different implementations ("acting on their admin interface" vs copying the databases / config files) this one does seem much easier to migrate.

In fact, given the move away from PHP to a new REST API, this project may become even easier!

I'm planning to do some testing on this project soon :)

Already done the migraton and it works. Just now waiting for v6-support and v6 release of Pihole :)

timtjtim commented 2 months ago

I'm going to split this into two PRs - the first will just change more into a factory pattern, but still only support v5. If we're happy with the approach, I'll add in the V6 stuff. In the meantime - in case I have to go AWOL for some reason - I've also added the basic v6 work I've done to another branch.

PR with factory pattern for comment: https://github.com/mattwebbio/orbital-sync/pull/406 Extra branch for safe-keeping: https://github.com/timtjtim/orbital-sync/blob/timtjtim/development-v6/v6-client-code/src/client/v6/index.ts