mattwebbio / orbital-sync

Synchronize multiple Pi-hole instances
http://orbitalsync.com
MIT License
550 stars 21 forks source link

Different env variables name #342

Closed RiKap closed 2 months ago

RiKap commented 2 months ago

What happened?

Hey, based on configuration file I should use NOTIFY_SMTP_ENABLED, NOTIFY_SMTP_FROM, ..., but based on schema.ts, it is SMTP_ENABLED, SMTP_FROM, ....

So there is a configuration mismatch as it contains a redundant NOTIFY_ prefix. It happened in this commit https://github.com/mattwebbio/orbital-sync/commit/cb622b334f4fd6fe4fdaa6e575b1f9b0e99cfb68

Version

master, v1.7.0, v1.8.0, v1.8.1

Log output

No response

mattwebbio commented 2 months ago

The environment variables listed on the Configuration page are the new ones that should be used. The ones explicitly listed in schema.ts are from an older version and have just been kept for backwards compatibility :)