Closed Hazegard closed 1 month ago
This is amazing! Thanks so much for figuring this out :)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.52%. Comparing base (
103155c
) to head (c9eea45
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The
persistentlogin=off
snippet in the request makes the server to respond the cookiepersistentlogin
, which will then be send in the POSTteleporter.php
request when uploading backup, which will cause the pihole server to respond: "Not authorized" when this cookie is sent.Removing this snippet in the login request removes the
persistentlogin
in the response. Conesquently, the archive upload is accepted by the pihole sever.=====
When using orbital-sync, I have the following logs:
I tracked the upload failure, and it is related to the
persistentlogin
cookie being sent with the upload request:When I try the same request without this cookie, the upload works:
This cookie comes from the
&persistentlogin=off
part of the request sent during the login (https://github.com/mattwebbio/orbital-sync/blob/master/src/client/v5/index.ts#L42)When this part is appended to the request, the
persistentlogin
cookie is received (and is then sent during the backup upload request):When i remove this part, the cookie is not set and the upload works:![image](https://github.com/mattwebbio/orbital-sync/assets/11147206/65d40e78-f106-4421-bd25-971f0efba546)