search

mattwparas / helix-config

34 stars 2 forks source link

Problem with open-term/xplr #5

Open mattwparas opened 4 months ago

mattwparas commented 4 months ago 
          @mattwparas hi, i have problem with ur config open-term/xplr
image

on mac zsh is located /bin/zsh

Originally posted by @StringNick in https://github.com/helix-editor/helix/issues/8675#issuecomment-2223051565

mattwparas commented 4 months ago

For this, you have to set the default shell, so put this in your init.scm:

(require (only-in "term.scm" set-default-shell!))
(set-default-shell! "path/to/my/shell/here")
StringNick commented 4 months ago

For this, you have to set the default shell, so put this in your init.scm:

(require (only-in "term.scm" set-default-shell!))
(set-default-shell! "path/to/my/shell/here")

yes, i put it, temrinal and xplr openning, but after close terminal or try to open file xplr bugging, screen above is for terminal quit

mattwparas commented 4 months ago

so just to clarify, I believe the exit and the shell path issue are two different things. This should just solve the path to the shell

mattwparas commented 4 months ago

The exit behavior is something else from the path issue. I'm attempting to reproduce that but currently unable to

mattwparas commented 4 months ago

From a clean slate, what happens if you run :kill-active-terminal instead of exit from the terminal?

StringNick commented 4 months ago

From a clean slate, what happens if you run :kill-active-terminal instead of exit from the terminal?

kill-active-terminal closing terminal and no issues

if i try to open file from xplr, happend just this:

image

i just call exit in terminal and helix is crashing after it

mattwparas commented 4 months ago

I'll work on the exit issue in the terminal, I'll have to get set up on a mac to try to reproduce, the behavior on linux does not appear to be the same.

For xplr, can you provide a screenshot right before you try to open a file?

mattwparas commented 4 months ago

Okay, I was able to reproduce the exit issue on mac, I'll have a fix later today

StringNick commented 4 months ago

@mattwparas

image

after

image
StringNick commented 3 months ago

@mattwparas 1) also ctrl - c (interrupt signal not working in terminal) 2) is it possible to open terminal as helix window (horizontal or vertical split)?

mattwparas commented 3 months ago

I've pushed a possible fix for the xplr issue - let me know if it makes a difference for you since I'm unable to reproduce myself. I've also pushed a fix for ctrl c as well

It is not possible to open the terminal as a helix window as of now

StringNick commented 3 months ago

I've pushed a possible fix for the xplr issue - let me know if it makes a difference for you since I'm unable to reproduce myself. I've also pushed a fix for ctrl c as well

It is not possible to open the terminal as a helix window as of now Same new empty tab with lambda, but now i saw that he is executing some command in terminal (./xplr PATH_TO_FILE)

https://github.com/user-attachments/assets/9ae65a88-8b41-44b6-80d5-46ec9c862a88