Closed wmedrano closed 6 months ago
This LGTM - any objection to the fact that it panics? I think in this path the idea was fail fast early and loudly, but I could see an argument for not doing that
This LGTM - any objection to the fact that it panics? I think in this path the idea was fail fast early and loudly, but I could see an argument for not doing that
Maybe. I don't think I have enough experience to make an informed opinion yet. At the moment the panic only slightly annoyed me in the repl since the following caused a crash which exits the repl:
(#%require-dylib "libmylib" (only-in typo))
Works for me, if you become increasingly annoyed we can adjust it to not panic. Should be an easy change and we can follow up with it if necessary, doesn't block this by any means
Also slightly simplify
maybe_get_environment_variable
.