search

mattwparas / steel

An embedded scheme interpreter in Rust
Apache License 2.0
1.05k stars 49 forks source link

Parse complex numbers. #164

Closed wmedrano closed 6 months ago

wmedrano commented 6 months ago

I should do some more reading into steel-core/src/compiler, but at least the tests pass!

I closed all the conversations with comments that seem fine so program.rs seems to be the sketchiest part.

mattwparas commented 6 months ago

I should do some more reading into steel-core/src/compiler, but at least the tests pass!

I closed all the conversations with comments that seem fine so program.rs seems to be the sketchiest part.

Yeah :sweat_smile: things get a little gnarlier in the compiler there.

I spot checked it and I'm reasonably confident the change is right. That pass is just checking if the constant is either 0, 1, or 2 (integer) - which you kept in place, so that seems fine.

wmedrano commented 6 months ago

oh yeah, the usage was pretty simple. I think this is good to go. I can also split this into smaller PRs if you'd like. The token refactor had a lot more changes than I expected.

mattwparas commented 6 months ago

oh yeah, the usage was pretty simple. I think this is good to go. I can also split this into smaller PRs if you'd like. The token refactor had a lot more changes than I expected.

No need, I'll do one more pass and otherwise I think its good as well