`register_value_with_doc` doesn't utilize the doc part

mattwparas / steel

An embedded scheme interpreter in Rust

Apache License 2.0

981 stars 46 forks source link

`register_value_with_doc` doesn't utilize the doc part #194

Closed shenlebantongying closed 2 months ago

shenlebantongying commented 2 months ago

I was looking at the doc and how the doc are generated.

It appears that various built-in functions are missing in the generated documentation (the book) and the built-in (help indent), such as cons, reverse...

All these are missing, (help cons) doesn't print CONS_DOC

https://github.com/mattwparas/steel/blob/d81f428767ad8872beaf628791b7351df320b147/crates/steel-core/src/primitives/lists.rs#L92-L95

mattwparas commented 2 months ago

Thanks for the report. I looked into it and it's just a bit of an oversight as I changed some of the implementation with doc handling. I'll have a PR today which updates them to be included

mattwparas commented 2 months ago

Should also be fixed in #193 - I just tacked it in there