search

mattwparas / steel

An embedded scheme interpreter in Rust
Apache License 2.0
1.07k stars 50 forks source link

simplify `flake.nix` #261

Open MatrixManAtYrService opened 3 weeks ago

MatrixManAtYrService commented 3 weeks ago

I'll confess to not really knowing what's going on here. I just saw that there was a flake.nix here, so I dropped into a devshell and got an error about a hash mismatch. This PR updates it to the "correct" hash according to my experience.

Thought you might like to know, sorry I can't provide more context--I'm new to this project, although I'm looking forward to getting to know it better.

mattwparas commented 2 weeks ago

thanks! I don't use nix so these issues seem to pop up every once in a while. Perhaps I should start using it

MatrixManAtYrService commented 2 weeks ago

Nix has its perks, and its pitfalls. I think it's worth it :man_shrugging:

I don't know cargo or lasso well enough to be confident about the specifics, but it seems like maybe this change altered the content of lasso (July 18). The hash was defined here (May 10). So I think I've just changed it to be a hash of the July 18 lasso instead of the May 10 lasso.

One thing I notice is that lasso is the only dependency in Cargo.lock with a source starting with git+, while everything else has a source starting with registry+. The doc for buildRustPackage talks about why the git dependencies require extra work.

From a cursory read of that doc, it would seem like in order for the hash to go away entirely, this would have to not be a git dependency.

mattwparas commented 1 week ago

So it looks like the lasso dependency now has an up to date cargo dependency, which would mean we wouldn't need this has anymore.

MatrixManAtYrService commented 1 week ago

That's good news. After rebasing I find that I can remove the hash and nix build still completes without trouble 😄