search

mattydebie / bitwarden-rofi

Wrapper for Bitwarden https://github.com/bitwarden/cli and Rofi
GNU General Public License v3.0
351 stars 57 forks source link

Fix AUR PKGBUILD #21

Open mattydebie opened 5 years ago

mattydebie commented 5 years ago

Now that we depend on lib/helper.sh, we also need to install that to a place on users' filesystem. Right now we expect the file to be in $PWD/lib/helper.sh which is not the correct place when installing bwmenu to /usr/bin/bwmenu.

mattydebie commented 5 years ago

renamed lib/helper.sh to lib-bwmenu and added it to install with PKGBUILD for bitwarden-rofi-git.

Mange commented 5 years ago

I would actually recommend to just inline the file. It's only used in a single place, so I don't see the need to have it in a different file in the first place.

mattydebie commented 5 years ago

That is also a correct assumption :stuck_out_tongue:

remyrd commented 5 years ago

I created that file because i don't like scrolling :) and it makes the codebase more readable IMO. I'm wondering if it's possible to generate a single file by dereferencing the source commands at install time... no idea if this exists in bash.

remyrd commented 5 years ago

Hey guys, just chiming in to let you know this project inspired me to write this https://github.com/remyrd/jimpass over the last few weeks in my free time.

I had many ideas in mind, but keeping everything in a single file and bash would have never been possible. I warmly invite you to take a look at what I did. If you're interested I'll gladly make you contributors or something (not sure what github offers in this regard).

Again, thanks for the inspiration!

mattydebie commented 5 years ago

That's looking quite good! I also was thinking about using python or go in stead of bash but here we are :stuck_out_tongue: Good luck with the project!