mattydebie / bitwarden-rofi

Wrapper for Bitwarden https://github.com/bitwarden/cli and Rofi
GNU General Public License v3.0
351 stars 57 forks source link

Use ydotool when available for wayland users #25

Closed touste closed 5 years ago

touste commented 5 years ago

ydotool is a replacement for xdotool that works in Wayland. If it is detected, it could replace xdotool to type username and password for Wayland users.

Note that it requires root permissions to run, so it should be called with sudo and the user should allow this in visudo (ex: user ALL=(ALL) NOPASSWD: /usr/bin/ydotool).

Thanks!

mattydebie commented 5 years ago

I think I came across it too one time in the past. Having to insert a line into visudo is not really an easy setup anymore. You should be able to just download the bash script and run it. Anyways, as I use X, I can not test this. PR's are always welcome! :smile:

touste commented 5 years ago

Thanks for the feedback, I agree that it is not an ideal solution but at the moment it's the only one available for Wayland users to my knowledge. I'll try to update the code and make a PR.

On Wed, Jun 19, 2019 at 9:11 AM Matthias De Bie notifications@github.com wrote:

I think I came across it too one time in the past. Having to insert a line into visudo is not really an easy setup anymore. You should be able to just download the bash script and run it. Anyways, as I use X, I can not test this. PR's are always welcome! 😄

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattydebie/bitwarden-rofi/issues/25?email_source=notifications&email_token=AAWLXEBXGFFDHANTLKTIHQDP3HL3PA5CNFSM4HZDPX3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYA5OHA#issuecomment-503437084, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWLXEF22A4J6FHM4AR5MYTP3HL3PANCNFSM4HZDPX3A .

mattydebie commented 5 years ago

True, it's better to provide something rather than nothing :grin: Thanks for your time!