search

mattydebie / bitwarden-rofi

Wrapper for Bitwarden https://github.com/bitwarden/cli and Rofi
GNU General Public License v3.0
351 stars 57 forks source link

Use ydotool when available, ability to change keyboard shortcuts #26

Closed touste closed 5 years ago

touste commented 5 years ago

3 changes were made:

  1. Add AUTOTYPE_MODE variable and fill it either with xdotool or ydotool depending on which is installed on the system. This allows Wayland users to have autotyping working, assuming that ydotool has root permissions without asking for password.

  2. Put the keyboard shortcuts in variables so that they can be easily changed.

  3. Check for user-defined AUTOTYPE_MODE and CLIPBOARD_MODE variables. If it is set, use these commands (I believe it was the intended behaviour but the program was overriding these variables).

This has been tested in Wayland, please test it in Xorg to make sure there is no unexpected behaviour.

mattydebie commented 5 years ago

I think this looks fine, although I can not check the wayland part. The xorg still works so if you squash your commits, and add your name to the contributors in the readme, I'll merge this! Thanks for the PR :grin:

touste commented 5 years ago

Done! I made one last useful change, I defined the default action when pressing Enter on an item in a variable so that it can be easily changed to auto_type all instead of copy_password for example.

mattydebie commented 5 years ago

fixes #25