WIP: Add possibility of showing usernames for items

mattydebie / bitwarden-rofi

Wrapper for Bitwarden https://github.com/bitwarden/cli and Rofi

GNU General Public License v3.0

351 stars 57 forks source link

WIP: Add possibility of showing usernames for items #37

Open mihalea opened 4 years ago

mihalea commented 4 years ago

Previously, usernames could be visible just for duplicate items, however it might be useful to see them for unique items too. Flag '--show-username' has been added to allow for such functionality.

This functionality however adds a dependency for Bash 4.0. But considering that this version of Bash has been released in 2009, I wouldn't consider this to be an issue.

mihalea commented 4 years ago

Part of the code introduced increases the time it takes to start the window by 3.5-4 seconds. I am currently investigation why and ways to reduce it. In its current state, I would advise against merging the pull request.

mattydebie commented 4 years ago

Thanks for taking the time to create and investigate this PR! Looking forward to the result