search

mattyg / herddit

P2P sub-group posting app on holochain
12 stars 1 forks source link

feat: rmvote #39

Open mrbianchi opened 1 year ago

mrbianchi commented 1 year ago

Allow neutral vote (0)

mattyg commented 1 year ago

Thanks for the PR!

Is the user-facing idea of this feature to remove a vote that you have already cast? So for example, if I upvote a post, then decide I want to remove that upvote, I can instead cast a 0 vote to supersede my upvote? Makes sense to me!

mrbianchi commented 1 year ago

Thanks for the PR!

Is the user-facing idea of this feature to remove a vote that you have already cast? So for example, if I upvote a post, then decide I want to remove that upvote, I can instead cast a 0 vote to supersede my upvote? Makes sense to me!

That would be my intention. Perhaps deleting the action would have been more assertive instead of issuing another one with a value of 0?

mattyg commented 1 year ago

Thanks for the PR! Is the user-facing idea of this feature to remove a vote that you have already cast? So for example, if I upvote a post, then decide I want to remove that upvote, I can instead cast a 0 vote to supersede my upvote? Makes sense to me!

That would be my intention. Perhaps deleting the action would have been more assertive instead of issuing another one with a value of 0?

yeah I agree I think deleting the previous vote makes more sense.