search

mattyr / sidecloq

Recurring / Periodic / Scheduled / Cron job extension for Sidekiq
MIT License
88 stars 12 forks source link

Require activesupport #20

Closed stmllr closed 6 years ago

stmllr commented 6 years ago

JobEnquer uses String method constantize from gem "activesupport", however this dependency is missing in Gemfile.

Non-rails projects fail with 

["error enqueuing example_job - NoMethodError: undefined method `constantize' for \"My::ExampleWorker\":String"]

I propose to add "activesupport" to Gemfile and use require "active_support/core_ext/string" in JobEnquer.

stmllr commented 6 years ago

If constantize is the only feature used from activesupport, I'd rather implement this instead of using activesupport.

mattyr commented 6 years ago

That's an excellent idea! Feel free to send over a pull request; or I can take a look sometime soon.

stmllr commented 6 years ago

There you go.