Clean up dependencies - Githubissues

mattyr / sidecloq

Recurring / Periodic / Scheduled / Cron job extension for Sidekiq

MIT License

88 stars 12 forks source link

Clean up dependencies #6

Closed ppostma closed 7 years ago

ppostma commented 7 years ago

Drop sinatra (not required and removed in Sidekiq 4.2)
Replace multi_json with standard json library
Move redis-namespace to development dependencies

mattyr commented 7 years ago

could you rebase your two latest pull requests real quick? i had to fix the CI setup.

ppostma commented 7 years ago

Sure, done.

ppostma commented 7 years ago

Hmm removing sinatra automatically makes bundler pull in the newest rack (v2) and that makes the builds fail with Ruby < 2.2.

If we want to remain compatibility with older Ruby then we might need to add a dependency on rack ~> 1.5.

mattyr commented 7 years ago

yeah, i noticed that. i don't want to impose too strict a version requirement like that across the board. I think that sidekiq 3.5.x still holds rack to the older, compatible version.

I'll merge this for now -- there are a few other CI cleanup things that I'll take care of today. Once it's green I'll push a new gem version.

Thanks again for the contributions!

mattyr commented 7 years ago

... ended up adding a note to the readme, and using a runtime check in the gemfile to get the builds passing. just release 0.3, thanks again!

ppostma commented 7 years ago

Cool, thank you for the new release!