search

mattyschell / geodatabase-buildings-condoetl

Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Review mappluto_bbl values #6

Closed mattyschell closed 1 year ago

mattyschell commented 2 years ago

A colleague at NYC Emergency management reports discrepancies comparing mappluto_bbl values we produce here to actual values in MapPLUTO. Seems bad!

Quickly reviewing these I see a couple of possibilities to track down. Sometimes we have multiple condos on a single building footprint and we remove duplicates at random. Let's revisit this decision, and I use the word "decision" loosely.

We also may have cases where the condo value reported in MapPLUTO is different from the value we fetch from the live the Dept of Finance condo dataset. We chose the Dept of Finance value because it seemed like it would be the most truthy. But if the point of this repo is to provide helpful values that join to MapPLUTO then why are we populating the buildings dataset with good but ultimately not useful values?

mattyschell commented 2 years ago

oti_buildings_wrong_mappluto_bbls_20220915.csv

mattyschell commented 2 years ago

The SQL at the center of this investigation:

https://github.com/mattyschell/geodatabase-buildings-condoetl/blob/d5c2d84d98aac535067f629e3fd83dad20b26c35/condoloader.py#L103

mattyschell commented 2 years ago

Related #5

wmc281 commented 2 years ago

Hi @mattyschell. You may have already spotted this. In addition to the condo issue, there are also a handful of records where the block/lot are in sync, but the first digit borough code in BBL values are different. That is strange. image

mattyschell commented 2 years ago

Thank you formerly anonymous colleague @wmc281 . Great to see you helping us out here on GitHub. I've responded to your additional issue, which I had definitely not yet spotted, with the best emoji GitHub has to offer for this.

Thanks again for these reports, feel free to open up new issues or comment on existing ones any time you like.

mattyschell commented 2 years ago

https://github.com/mattyschell/geodatabase-buildings/issues/14

Building bin/bbls in different boros is a known issue, resolution TBD.

mattyschell commented 1 year ago

I reviewed this excellent list and I see three distinct issues.

  1. A couple of out of synch values between OTI mappluto_bbl and DCP mappluto. This is inevitable. These are almost always xxxxxx75xx bbls that have been created or destroyed recently.
  2. A larger category of buildings that do not exist on tax lots. They're in easements and so on we know these they are ok.
  3. Most importantly: Most numerous are building base_bbls that do not exist in the Dept. of Finance tax lots or in Dept of City Planning Pluto. These are bad building bbls, they were typo'd or the tax lots no longer exist.

We will upgrade https://github.com/mattyschell/geodatabase-buildings-bbl-qa to flag category 3. I am closing this issue under this repository.

Thanks again @wmc281 great QA here! Stay tuned.