search

matus-chochlik / ctcache

Cache for clang-tidy static analysis results
Boost Software License 1.0
84 stars 30 forks source link

Client/server mode no longer working by default #30

Closed tonygould closed 1 year ago

tonygould commented 1 year ago

Following doesn't work any more

This mode is enabled by setting the CTCACHE_HOST (localhost by default) and optionally CTCACHE_PORT (5000 by default) environment variables.

This is after commit a10ce62b6d237bcdd531f08a8fa9401a28640573. Simplest fix is to change the new option 

    def save_output(self) -> bool:
        return os.getenv("CTCACHE_SAVE_OUTPUT", "1") == "1"

so that it returns false by default, maintaining the old behaviour by default, i.e. return os.getenv("CTCACHE_SAVE_OUTPUT", "0") == "1".

matus-chochlik commented 1 year ago

Hi, I've pushed the suggested change to main. Thanks for the bug report

tonygould commented 1 year ago

Thanks -- and thank you for ctcache; I'm enjoying using it!

On Wed, 18 Oct 2023 at 05:58, Matus Chochlik @.***> wrote:

Hi, I've pushed the suggested change to main. Thanks for the bug report

— Reply to this email directly, view it on GitHub https://github.com/matus-chochlik/ctcache/issues/30#issuecomment-1767642727, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUL532P7AW4BTUOHZDLLWC3X75OWFAVCNFSM6AAAAAA6DQQSQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGY2DENZSG4 . You are receiving this because you authored the thread.Message ID: @.***>