matus-chochlik / ctcache

Cache for clang-tidy static analysis results
Boost Software License 1.0
79 stars 28 forks source link

do not ignore cache data if it is empty #42

Closed N-Coder closed 5 months ago

N-Coder commented 5 months ago

Currently, an empty string/entry is ignored by ClangTidyCache.get_cache_data, resulting in None being returned. Thus, a cache hit will be ignored and clang-tidy still run if the entry is empty and save_output is enabled. This also contrasts run_clang_tidy_cached that correctly checks if data is not None instead of only if data.

matus-chochlik commented 5 months ago

merged. Thanks for the PR.