search

matus-chochlik / ctcache

Cache for clang-tidy static analysis results
Boost Software License 1.0
83 stars 29 forks source link

Fixing web background and image clipping issues #48

Closed greg-kent closed 6 months ago

greg-kent commented 6 months ago

A couple of issues for the ctcache web ui (found and fixes tested on chrome, firefox on mac)

  1. The images were created with a dark theme so the labels/axis have a white font. No background colour was set so the background would default to white, and hide the axis etc. The fix sets the background colour to the same colour as on the example image on github.
  2. Some webpage aspect ratios would hide the y axis labels of the grids. Resizing the webpage smaller and with more width than height would resize the images in a way that the y axis labels would be shown again. This changes how the images are saved and the images now show the y label for all webpage height/widths.
matus-chochlik commented 6 months ago

Merged. thanks for the PR.