Closed PatrickKa closed 3 months ago
LGTM after a quick review, we'll see if it breaks anything.
That's the spirit 😄. I just realized that I didn't look through the README, though. I guess it will need some changes. It should at least mention that clang-tidy-cache
can be installed with pip as well now.
it's not ideal, I have a long TODO list with things like testing of ctcache and cpack packaging of ctcache somewhere on it :P I'll have a look at the readme (and the other documentation as well)
Right now, ctcache is installed by copying Python scripts manually. The execution of the scripts also relies on the shebangs, which AFAIK are not supported, i.e., do nothing on Windows. This is inconvenient for me, so I suggest turning this project into a proper Python package that can be installed with pip. Publishing the package on PyPI is not necessary. I am happy with installing it from source or version control systems in this case Git:
I tried to change as little as possible to make this work.
pyproject.toml
_
instead of-
and add.py
file extensionRegarding the last point, I am not well versed in bash scripts or Dockerfiles. Please check if the installation scripts still work and the Dockerfile is correct.
Please, also take a look at the metadata provided in
pyproject.toml
. See Writing yourpyproject.toml
from the Python packaging user guide for more information. So far I only madeclang-tidy-cache
installable, and added its required dependencies. I think installing the server script should be an optional "extra". The same goes for the support of Google Cloud Storage, S3, etc.