Add smart_passed metric and basic information about devices

matusnovak / prometheus-smartctl

HDD S.M.A.R.T exporter for Prometheus written in Python

The Unlicense

155 stars 43 forks source link

Add smart_passed metric and basic information about devices #40

Closed matt400 closed 2 years ago

matt400 commented 2 years ago

This change is adding model_family, model_name, serial_number to metrics labels, because it makes things easier to identify devices in Grafana. I could do this by changing -A parameter to -a in smartctl command, this way I got more data. I don't think this is the best approach, but it's best I could think of right now.

I've also added new metric smartprom_smart_passed where values are 1, 0 or -1 when undefined.

ngosang commented 2 years ago

@matt400 I did several changes in your code:

-a was slower in my system because it gets more info than we need. I use -A -H instead
device info is grabbed on start
added device type attribute
changed device attribute to include the full path. This could be consider a breaking change but it's the right way
cleaner code without tuples

ngosang commented 2 years ago

@matt400 @PhilipMay https://github.com/matusnovak/prometheus-smartctl/releases/tag/v2.1.0