search

matuzo / HTMHell

A collection of bad practices in HTML found on real websites.
MIT License
568 stars 67 forks source link

feat: add Meiert advent calendar entry #152

Closed j9t closed 1 week ago

j9t commented 1 month ago

@matuzo, do you do an editorial review as well, or better to seek this separately? (Open either way, but will appreciate a peer review.)

matuzo commented 1 week ago

I'll suggest changes if I see anything but if you want to double check ask someone else to do an editorial review.

matuzo commented 3 days ago

Hey Jens, thanks a lot for your great post. We've added some comments directly in your file in the advent24 branch of the HTMHell repository. Sorry that we're not using GitHub and it's comment feature as intended but our approach makes it easier for us since not all authors are using GitHub.

Please review our comments, make your changes if necessary, and submit another PR. If you have questions please ask them here.

Thanks a lot, Manuel, Saptak, and Karl

j9t commented 3 days ago

@matuzo, I’m having a look. Will open a new PR then.