search

matvp91 / shaka-player-react

A simple React component wrapper for shaka-player
MIT License
112 stars 34 forks source link

UI control not work #8

Open ducxinh opened 4 years ago

ducxinh commented 4 years ago

Hey.

Can you tell me where I went wrong? Looks like My code lacks style for control

video-result
tomastuser commented 4 years ago

I am also having this problem. Did you figure it out in the end?

matvp91 commented 4 years ago

@tomastuser Could you provide a sample project (codesandbox)?

tomastuser commented 4 years ago

Here is the codesandbox sample: https://codesandbox.io/s/wonderful-feistel-eulvy

I managed to find a workaround by adding a CSS class called .material-icons and referencing the Material Icons Round font face in it. When inspecting the UI elements in browser it looks they all use .material-icons selector but in controls.css provided by shaka-player they only reference material-icons-round.

Also the video in fullscreen mode doesn't stretch and continues to stay small as can be seen in the sample. Should I open another issue for this problem or is it ok to report it here?

matvp91 commented 3 years ago

@tomastuser @ducxinh201 I'm sorry it took such a long time for me to answer to your issue. Before I'd want to investigate your issue, I first made sure shaka-player-react is properly migrated to shaka-player's latest stable version (3.0.6).

I quickly made a codesandbox to verify if this is still an issue with the updated shaka-player version, and it doesn't seem so. You can see the result here: https://codesandbox.io/s/condescending-benz-ybhih. Could you upgrade to v1.1.0 and give it another spin?

As a side note, I've imported the css directly from shaka-player/dist/controls.css and let the bundler deal with it.