matvp91 / superstreamer

An open, scalable, online streaming setup. All-in-one toolkit from ingest to adaptive video playback. Built for developers in need of video tooling.
https://matvp91.github.io/superstreamer/
Mozilla Public License 2.0
318 stars 12 forks source link

Player does not show LANGUAGE but uses NAME tag for subtitle and audio selection. #38

Closed matvp91 closed 1 week ago

matvp91 commented 1 week ago

Describe the bug We don't take LANGUAGE into account for EXT-X-MEDIA tags. Run this playlist, https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8, in the player and you'll notice that the names of the audio tracks in player are not correct.

Expected behavior Use LANGUAGE as the primary label for audio tracks, and fallback to NAME.

Additional context Today we simply take NAME, lowercase it, uppercase the first character and use that as the label. While this works for assets that are produced with Mixwave (eg; the NAME is set as uppercase language by the packager), this will fail when we play playlists from elsewhere.

See EXT-X-MEDIA - LANGUAGE in the HLS spec: https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis

Extra

hot-cacao commented 1 week ago

Can I have this issue?

matvp91 commented 1 week ago

Sure! Have fun.

matvp91 commented 1 week ago

Added in https://github.com/matvp91/mixwave/commit/e4a5cd952062a6ebf1e740bf4e07ea2c06dbc245