search

matype / stylefmt

stylefmt is a tool that automatically formats stylesheets.
Other
2.1k stars 89 forks source link

fix handling of functions in @for statements (#275) #308

Closed modosc closed 4 years ago

modosc commented 7 years ago

should fix #275

modosc commented 7 years ago

ping?

ghost commented 6 years ago

Looks like author forgot about him project. Maybe we should fork new version for development of new versions? And if author back, we just can return him project.

modosc commented 6 years ago

@dmitriy-lodyanov see also https://github.com/stylelint/stylelint/issues/2829 - it seems like the author is recommending people use stylelint --fix instead. i think most of these rules are portable to that, i'm going to open a test pr with some of the work i've done here to see if they accept it.

if not, i'll fork and maintain this project.

ghost commented 6 years ago

I know about stylelint --fix, and i can say - there is problem for some cases. stylelint --fix didn't provide api for get result of fixed version, so we can't make a plugin for vscode for example (vscode api working with code text range instead of file). I think, other code editors have same issues. Yes, do fork and if you want, i would be glad to help you with fork as maintainer, or i will just send PRs sometimes.

modosc commented 6 years ago

stylelint --fix didn't provide api for get result of fixed version, so we can't make a plugin for vscode for example (vscode api working with code text range instead of file).

@dmitriy-lodyanov i see that the api docs show the fixes happen directly on the files. i'm going to start doing work in stylelint now, i'm going to file an issue over there to add an api for this. i think in the end doing the work inside of stylelint (just like eslint does) makes more sense than maintaining a separate package. if we could add a compatibility api that matches the stylefmt api then maybe porting plugins would be somewhat simple?

ghost commented 6 years ago

@modosc You definitely right about support and develop only stylelint. As i understand you going to make api for styleint for fixing text instead of fix file directly. And you want to make compatibility api matches the stylefmt in stylelint? For easing porting existing code editor plugins? Thats sounds great and i would be glad to help.