matze / jekyll-ditaa

Jekyll ditaa Plugin
MIT License
29 stars 9 forks source link

Configuration and cleanup of orphaned files added #5

Closed ghost closed 10 years ago

ghost commented 10 years ago

Hello Matthias,

I'm Fèlix, the one you talked to at StackOverflow regarding the cleanup and placement of generated files for this plugin of yours. I've just added some code to it in order to gain two new features:

I've also updated the README.md to document those changes.

I hope that's ok for you!

matze commented 10 years ago

Hi Fèlix, that's very nice, thanks for the PR.

I have one remark and maybe you have an opinion on that: You are now suppressing the ditaa output which is probably the right thing to do on success. However when something goes wrong, it would be very helpful to see the cause of the problem. Apart from that it looks good for merging.

ghost commented 10 years ago

Take a look now. I've added a simple ditaa_debug_mode to control that specific.

matze commented 10 years ago

That's great! Thanks for your submission.