Closed ghost closed 10 years ago
Hi Fèlix, that's very nice, thanks for the PR.
I have one remark and maybe you have an opinion on that: You are now suppressing the ditaa output which is probably the right thing to do on success. However when something goes wrong, it would be very helpful to see the cause of the problem. Apart from that it looks good for merging.
Take a look now. I've added a simple ditaa_debug_mode
to control that specific.
That's great! Thanks for your submission.
Hello Matthias,
I'm Fèlix, the one you talked to at StackOverflow regarding the cleanup and placement of generated files for this plugin of yours. I've just added some code to it in order to gain two new features:
_config.yml
parameter namedditaa_output_directory
. If not specified, it will get the default value hardcoded inside the plugin.ditaa-xxx.png
files and compare to the list of generated in this build. The program deletes all the extra files.I've also updated the README.md to document those changes.
I hope that's ok for you!