matze / vim-move

Plugin to move lines and selections up and down
http://www.vim.org/scripts/script.php?script_id=4687
MIT License
1.2k stars 56 forks source link

Fix #71 #72

Closed dzfrias closed 2 years ago

dzfrias commented 2 years ago

Problem

Some users have different terminal option key bindings, so the alt key would only work with a specific portion of users.

Fix

Default to assuming ESC+ is sent with the alt key, and provide an option (g:move_normal_option) in case the user wants to use ∆ or ˚ etc.

NOTE

Further discussion about the best way to handle the alt keys may be needed.

matze commented 2 years ago

Further discussion about the best way to handle the alt keys may be needed.

That means we should wait for some feedback?

dzfrias commented 2 years ago

Further discussion about the best way to handle the alt keys may be needed.

That means we should wait for some feedback?

We might want to merge it right now so it fixes it for the people who the plugin broke for. The second-to-last comment I made on #71 describes the discussion pretty well. I think fixing it right now should be a higher priority than the discussion.

matze commented 2 years ago

Alright, thanks for taking care of that!