Open bt-nia opened 1 month ago
any update on this? :)
I left a change request a while ago, regarding the max_expiration()
function.
@matze can you please point me to it? I can't find it.
Wait, you can't see the "Please return Optionenv.rs
?
Not sure where I can see that? This is my change view:
I've never submitted change requests in Github, but I can say that in Gitlab it is easy to accidentally only submit comments for review but never actually post the review.
Thanks for sharing the change. Two comments:
Sorry, you couldn't see it until I submitted the review :see_no_evil:
Sorry, you couldn't see it until I submitted the review 🙈
No problem! 🍻
I was able to test the code now and made some improvements to the index.html template. I looked into your proposal, but from what it seems to me it is mostly a complication that makes value types less predictable. If you still believe that not returning an integer here would be beneficial, please let me know as to why.
That said, unless you see any glaring issues, in which case: please let me know, could we please merge this? It is a feature we would really like to use for our deployment :)
Disclaimer: I never programmed RUST and this is mostly LLM generated code
This aims to implement https://github.com/matze/wastebin/issues/54
cc: @matze @denissteinhorst for visibility