matze / wastebin

wastebin is a pastebin
MIT License
250 stars 25 forks source link

Would you be open to a PR changing from grid layout to flexbox layout? #60

Open kshannoninnes opened 1 week ago

kshannoninnes commented 1 week ago

Love the minimalist style, but it's bothering me that the content div is overflowing and creating a scrollbar. I've looked through the stylesheet a bit and played around, and I believe the cause is due to the way the grid layout is used (although I'm not 100% on this).

If you prefer to stay with the grid style, that's cool. I'll keep my forked version for my own usage.

matze commented 1 week ago

Do you have some example how you would like to have it? Not sure what the layout change would look like.

kshannoninnes commented 1 week ago

On further investigation I believe the scrollbar is actually mostly due to the way you've implemented the select box for languages. I'm not sure if there's a way to apply a dynamic size in this case, as 23 (with the spacing between elements in that right-menu) is too large and introduces a page scrollbar (screenshot below).

I think there are a couple potential ways of solving my issue.

I don't think any of the suggestions are good ones. It might be best for me to just keep a forked version for myself? Open to ideas. I've included a screenshot of the second option of changes that I implemented on my own copy below (ignore the random artifacts in the bottom right, that's the old screenshot behind it in paint).

Here's a link to my fork commit for the changes that achieve the second screenshot: https://github.com/kshannoninnes/wastebin/commit/238e53d5fca35601ceecd7c7bc1b9b3945736878

image image

matze commented 6 days ago

I'm fine reducing the size again. In fact the list used to be shorter.

matze commented 5 days ago

This can be closed then, right?