search

matze / wastebin

wastebin is a pastebin
MIT License
250 stars 25 forks source link

Reduce lang list size to fix overflow #61

Closed kshannoninnes closed 5 days ago

kshannoninnes commented 6 days ago

A scrollbar was getting introduced due to the size of the langs list. This reduces the size from 23 options to 17 options, and also adjusts some height attributes in other elements to remove the scrollbar completely.

matze commented 6 days ago

I think the removal of one of the margins caused this imbalance between paste content and language list:

Bildschirmfoto vom 2024-06-30 00-57-26

kshannoninnes commented 6 days ago

Odd. What browser are you using? I just tested firefox chrome and edge and they're all spaced out appropriately. Am I misunderstanding what you mean? Could it be related to the difference between light and dark theme? I didn't touch any of those, but also haven't looked too closely at how they work.

Edit: Wait I think I know what you mean. I removed the top margin, but added a top padding to the extensions-list, but didn't add it to the paste text area div.

(Also just realized I haven't fixed the scrollbar for the latter 2 browsers so will do that really quickly) image

matze commented 5 days ago

I also see it in your screenshot. The <paste text or drop file here> moved up a bit, the padding was on purpose and also matched the first line of the lang list.

kshannoninnes commented 5 days ago

Yeah I realized later on what you were referring to (in the edit of my last reply) and pushed the fix before your comment :)

matze commented 5 days ago

Looks, good, thanks!