search

matzefriedrich / zip-extensions-rs

Provides extensions for the zip crate
MIT License
20 stars 12 forks source link

Appending files and directories #18

Open Chaoses-Ib opened 4 days ago

Chaoses-Ib commented 4 days ago

create_from_directory() can only add a single directory and then finish(). Is it possible to add other methods like add_directory_recursive() and add_file() to allow more flexible file selection?

matzefriedrich commented 4 days ago

I appreciate your interest in zip-extensions-rs. The idea of adding new methods sounds promising for enhancing flexibility. To better understand your use case, could you provide more details on the specific features or behaviors you're looking for with these methods?

I’m open to collaboration on this, and if you have any implementation ideas, feel free to open a PR. It would be great to extend the functionality together. I'm looking forward to hearing your thoughts.

Chaoses-Ib commented 3 days ago

In our case, we want to pack some static files together with a dynamically generated file. I've already implemented this by copying and patching zip-extensions-rs‘ code, but I just found it uncomfortable that 90 lines of code are needed to just pack some files...

matzefriedrich commented 3 days ago

If I understand correctly, you already have code for your use case. If you think this could be interesting for others also, what´s hindering you from opening a PR?