search

matzefriedrich / zip-extensions-rs

Provides extensions for the zip crate
MIT License
20 stars 12 forks source link

Fix formatting and lints #6

Closed CosmicHorrorDev closed 3 years ago

CosmicHorrorDev commented 3 years ago

Hello, thanks for the crate! It made it really easy to setup zipping entire directories in my unit testing.

I'm planning on submitting a couple more PRs, but I wanted to get formatting and clippy lints / compiler warnings out of the way first. There are still some deprecation warnings from zip left to get through, but I was planning on setting up a different issue/PR to deal with that since it involves changing some of the behavior in this crate.

The formatting vs lints and warnings is broken out into two separate commits if you want to see the changes from each one just as a heads up.

matzefriedrich commented 3 years ago

Thanks for your contribution; give me some time to review the PR. And yes, those deprecation warnings you´re mentioning are already on my schedule but feel free to solve them if you like.

CosmicHorrorDev commented 3 years ago

Thanks for the quick response! Feel free to run cargo fmt and also follow the cargo clippy --all-targets suggestions locally and follow through the changes. It should be equivalent to this PR aside from some areas where I picked a more concise change like .unwrap_or_default() over .unwrap_or(false)