matzko / wp-db-backup

On-demand backup of your WordPress database.
http://austinmatzko.com/wordpress-plugins/wp-db-backup/
GNU General Public License v2.0
53 stars 31 forks source link

Wrong sender address when run wp-cron from command-liine #17

Open NoAnyLove opened 8 years ago

NoAnyLove commented 8 years ago

For some reasons (php-fpm request timeout, more accurate cron, etc.), I disable wp-cron by adding define('DISABLE_WP_CRON', true); in wp-config.php, and running wp-cron by adding */10 * * * * /usr/local/bin/php /data/wwwroot/blog/wp-cron.php in crontab.

This causes varaible $_SERVER['SERVER_NAME'] unset when wp-cron triggered from crontab. So the Scheduled Backup will send email with sender emaill address as wordpress without domain name. As a result, the email system simply treat it as a spam.

I think it may be better to improve the way of getting sitename. If the $_SERVER['SERVER_NAME'] is not available, we can sue site_url() function instead.

NoAnyLove commented 8 years ago

I tried to fix this in pull#18, it works on my blog with version 4.4.1. This is my first time writing php code, not sure if there is something wrong with my code.

I also try to make it compatible with versions below 3.0.0, but I didn't test it on an old version WordPress.