search

matzman666 / PyPipboyApp

A platform independent and extensible unofficial Fallout 4 Pipboy Companion App
GNU General Public License v3.0
83 stars 20 forks source link

Points of Interest #23

Closed akamal closed 8 years ago

akamal commented 8 years ago

Points of Interest (POI) can be placed at arbitrary locations on the global map, named and marked by a configurable icon (I drew one new one, there rest are repurposed from killeand's playerstats widget), and can be individually coloured. By default, both POIs and Notes are only shown to the character that created them (to prevent cross playthrough 'spoilers'.

Also: Refactored Notes, and per location sticky persistence Added overlay icon to indicate workshops

matzman666 commented 8 years ago

Really nice. There is one minor thing: When you don't enter any label, nothing happens. This is suboptimal in my opinion because there is no feedback for the user. I suggest two solutions: (1) Allow empty labels, or (2) an error message prompting the user to enter a label.

akamal commented 8 years ago

That's a fair point, I can't see any reason not to allow POIs without labels. I've got a few bug fixes in the works so I'll sort that out at the same time.

I've also put together a set of more appropriate icons that it would be nice to include, they're all licenced under the Creative Commons Attribution 3.0 Unported (CC BY 3.0) licence. It's not entirely clear to me whether this is compatible with GPL 3 or not. Do you know? Or would you rather I push them to the non-free repo just to be on the safe side?

matzman666 commented 8 years ago

There does not seem to be a consent whether GPL and CC BY are compatible. Some say yes, some say no. I would say let's put them into the non-free repository for now. We can always move them afterwards.