search

matzman666 / PyPipboyApp

A platform independent and extensible unofficial Fallout 4 Pipboy Companion App
GNU General Public License v3.0
85 stars 20 forks source link

Fixed bug with adding POI markers by adding In self.locMarkSize for m… #31

Closed gwhittey23 closed 8 years ago

gwhittey23 commented 8 years ago

Not sure why the absent of size was causing crash but added in size to the poimarker = PointofInterestMarker which should not size=24 def __init__(self, uid, widget, imageFactory, color, size=24, iconfile='mapmarkerpoi_1.svg', parent = None): size be set to 24 by default?

akamal commented 8 years ago

I saw that while working on the Collectables. It’s because size and iconfile are optional, and only iconfile was being provided to the constructor. As the first optional arg is size it was being incorrectly set to the iconfile string; which then causes a crash when it can’t be cast to an int.

It’s also fixed it in the pull request for the collectables.

matzman666 commented 8 years ago

I also fixed this in one of my commits. That's why there was a merge conflict in akamal's most recent pull request.