maubot / gitlab

A GitLab client and webhook receiver for maubot.
GNU Affero General Public License v3.0
95 stars 30 forks source link

Bad English message "approveded" in Merge request events #37

Closed cmuller closed 4 years ago

cmuller commented 4 years ago

Hello,

When selecting "Merge request events" in the Gitlab webhooks list, maubot gitlab is not formatting the right message. It tries to make a doubled past tense of "approved" and so we can see a message like:

[group / repo] User approveded merge request "description..."

This is due to the past_tense function in gitlab_matrix/gitlab_hook.py.

nanonyme commented 3 years ago

I suppose this still isn't deployed as the error is still present?

tulir commented 3 years ago

This is not a service, deploying updates is up to the admins of whatever instance you're using.

nanonyme commented 3 years ago

I see, thank you.