search

mauge123 / mechanical-blender

mechanical blender project
Other
70 stars 16 forks source link

better inset #11

Closed mirlip closed 8 years ago

mirlip commented 8 years ago

Would it be possible to integrate this patch https://developer.blender.org/D1669 ? It's from the dev of the bevel modifier and add self intersection detection to the inset operator, which is much needed in architecture and precision modelling. It rocks.

mauge123 commented 8 years ago

I'll contact the author ;)

Thanks!

mauge123 commented 8 years ago

It was applied on 7af74ee9371577d854f64c8a3cb71f09e818073b

mirlip commented 8 years ago

If you want, I made some corrections to make it compile on VS2013: http://www.pasteall.org/69758/diff It's the full diff from BF-master, so you may have to revert the old one first.

mauge123 commented 8 years ago

I can see the patch is using spaces for indentation, so it's hard to check changes if they are not replaced first. Blender uses tabs for indentation.

I also see you have changed inline for __inline, i see the first one is used in all other places in blender code ¿?

mirlip commented 8 years ago

Yes, only this __inline was important I think. For some reason, VS2013 doesn't like it in this case. Don't ask me why, it's MS :D

mauge123 commented 8 years ago

b9d6a4a9cd8e407bb3b23ce4e9cc2d52e9a16da2 includes the fixes you proposed to get compiled sucssefully on MSVC.

mirlip commented 8 years ago

I'm glad it worked without breaking Linux compilation :)