mauge123 / mechanical-blender

mechanical blender project
Other
70 stars 16 forks source link

suggestions for dimensions #3

Closed mirlip closed 8 years ago

mirlip commented 8 years ago

Hi, First of all, awesome job guys! The last fix worked like a charm, thank you. The new non-modal transform is really much better than previously. The dimensions are really well designed and pretty intuitive to use. But it is hard to read the text sometime. Would it be possible to:

mauge123 commented 8 years ago

Thanks for your comments ;)

PD: note that dimension information is saved on .blend file with mesh data. This means that if the file is opened and saved with a different binary (not from this project) dimension data will be loose. Also be careful as it's on development, and should not be considered stable, but is good to have people testing/using it ;)

mirlip commented 8 years ago

Thank you for your quick answer ;) Can't wait :)

mauge123 commented 8 years ago

56fab086d4b4c50362c7a94ccea39970ff4d3057 includes the first point, enabling or disabling mesh_dismensions in object mode.

mirlip commented 8 years ago

Hi Mauge, Nice :) Compiling on windows gives following errors: blender\source\blender\modifiers\intern\MOD_fluidsim_util.c(218): error C2198: 'CDDM_new' : too few arguments for call Note that it does this error for all modifiers and for smoke.c

mauge123 commented 8 years ago

277f5f6dbf1f4585eab1deded1e34c7dc465c01a should ammend it, if it was the only issue.

I've have not detected because i'm working on a really basic setting (all possible is disabled). I've changed the way it was done, as the function may be used around, and can due to future compiler errors not detected if something is disabled.

Thanks!

mauge123 commented 8 years ago

I'll try to set up a more complete setting for testing this issues.

Thanks!

mirlip commented 8 years ago

VS2013 still fails with following error:

Creating library C:/Users/test/git/build_windows_full/bin/Release/blenderplayer.lib and object C:/Users/test/git/build_windows_full/bin/Release/blenderplayer.exp
bf_bmesh.lib(bmesh_delete.obj) : error LNK2019: unresolved external symbol get_selected_dimension_BMesh referenced in function BMO_mesh_delete_oflag_context [C:\Users\test\git\build_windows_full\source\blenderplayer\blenderplayer.vcxproj]
C:\Users\test\git\build_windows_full\bin\Release\blenderplayer.exe : fatal error LNK1120: 1 unresolved externals 
mirlip commented 8 years ago

It compiles without player, and show dimensions work. But show dimensions on selected doesn't work. I also tried to duplicate (shift-D) a cube with dimentions (visible in object mode), entered edit mode on this copy, modified the dimension, then hit tab to go back to object mode and it crashed.

mauge123 commented 8 years ago

Show dimensions on selected works for me, but maybe is unclear, as show dimensions must be selected also.

Commited a fix solving crash related to duplicate.

Thanks!

mirlip commented 8 years ago

Thanks for the fix. For the selection only view, maybe call it restrict to selected object and make it greyed out when view selected is not activated?

mirlip commented 8 years ago

Edit: Better open a new ticket for it

mauge123 commented 8 years ago

41964561efe70ff37a5b1a864dc529d8cc20019c enables color customization fixed on 1a71a2ead220c7ab0df10ed502ef3a647b9e5638 (with WITH_PLAYER enabled)