search

maugenst / tabletojson

An npm module for node.js to convert HTML tables to JSON objects
https://www.npmjs.com/package/tabletojson
MIT License
138 stars 38 forks source link

Require secure version of request #20

Closed ksb86 closed 6 years ago

ksb86 commented 7 years ago

request@2.67.0 has a security vulnerability that was fixed in 2.68.0 https://nodesecurity.io/advisories/309

I tried manually updating the dependency to 2.68.0 in package.json in node_modules and didn't see any immediate issues..

Nordes commented 7 years ago

It's been fixed in the commit b72e11d. So normally you can close this issue ;). (Just saying)

iaincollins commented 7 years ago

Ty for the poke.

I promise will do an update soon (will close that when have rolled out an update to npm).

maugenst commented 6 years ago

Any updates on the used request version?

request itself is already on 2.8x.something ... Any objections to directly jump to latest version?

iaincollins commented 6 years ago

It's now on 2.85.0 thanks to @maugenst 🎉