iaincollins
commented
6 years ago Oh wow, that's awesome!
I haven't finished going though everything yet, but having both tests and test coverage checking would be wonderful.
I'm familiar with Travis for CI and Istanbul for checking test coverage, but I haven't used Coveralls before. It looks like the tests pass but the coverage checking seems to fail locally (from a quick Google I gather it looks like it's designed to run inside Travis CI and/or against code in a repo online.).
$ npm test
> tabletojson@0.7.1 test /Users/iain/Development/tabletojson
> npm run mocha && npm run coverage
> tabletojson@0.7.1 mocha /Users/iain/Development/tabletojson
> node_modules/nyc/bin/nyc.js --reporter=text node_modules/mocha/bin/mocha
TableToJSON Local
✓ Directly local html content: Table with header
✓ Directly passing html content: Table without header
TableToJSON Remote
✓ Get table from Wikipedia using callBack function (683ms)
✓ Get table from Wikipedia using promise (461ms)
✓ Get table from timeanddate.com and use first row as heading (313ms)
5 passing (2s)
----------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
----------------|----------|----------|----------|----------|-------------------|
All files | 84.38 | 67.65 | 100 | 83.61 | |
tabletojson.js | 84.38 | 67.65 | 100 | 83.61 |... 44,147,148,164 |
----------------|----------|----------|----------|----------|-------------------|
> tabletojson@0.7.1 coverage /Users/iain/Development/tabletojson
> node_modules/nyc/bin/nyc.js report --reporter=text-lcov node_modules/mocha/bin/mocha |node_modules/coveralls/bin/coveralls.js
/Users/iain/Development/tabletojson/node_modules/coveralls/bin/coveralls.js:18
throw err;
^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}I've added you as collaborator if you'd like to push to master.
As this repo isn't in an organisation, it doesn't look like I can add you as an admin who can manage the settings for the repo.
I'm happy to either add this repo to an organisation to do that, to set up Travis for the Repo, or - and this might make the most sense if you are willing - to transfer ownership of the repo to you on GitHub and NPM, and for me to just remain on as a collaborator, with you as the owner going foward?
This has been a low maintenance project but I've got slightly more projects than I am managing to look after well and has been neglected by me as no-one has been complaining about it, and it might be good for it to have a better home where someone does a better job of tending to it? :-)
Regardless, I'm happy to continue however you like. I think this is a great way to go.
maugenst
Hi Iain.
I worked on enabling testing and also added batches to be shown at the top of the README.md.
Currently npm run test would fail since the used travis-ci.org and coveralls.io are not added as trusted apps in github (travis-ci.org) or have not added .coveralls.yml (coveralls.io) what just you as the owner can do.
If you find it helpful please have a look into my forked repo. And if you think this could be the way to go please get back to me and I can help on adding the needed files...
CU, Marius