search

maugenst / tabletojson

An npm module for node.js to convert HTML tables to JSON objects
https://www.npmjs.com/package/tabletojson
MIT License
138 stars 38 forks source link

Adding support for Complex Rowspans #44

Closed maugenst closed 4 years ago

maugenst commented 4 years ago

Like described here: Complex Rowspans

It would be nice to support also Complex rowspans that lead to correct objects.

maugenst commented 4 years ago

Already added a failing test on this issue. test Complex Rowspan

piranna commented 4 years ago

Fixed in #45

piranna commented 4 years ago

Can this be closed now?

piranna commented 4 years ago

Closing .... Thanks !!!!

You are welcome! :-)

maugenst commented 4 years ago

Did you really test this against the test I implemented in the separate branch?

I recently checked this and it still fails:

maugenst commented 4 years ago

I Implemented a test ... Please check out the latest version and check your implementation against it.

piranna commented 4 years ago

I have just clean-up my node_modules and tests are passing will all the merged code in master...

maugenst commented 4 years ago

Sorry ... I was wrong ... I just ran the test and it works like a charm ... :-) Sorry for the confusion!!!

I'll push it to npmjs with a new minor version 1.2 ...

piranna commented 4 years ago

Sorry ... I was wrong ... I just ran the test and it works like a charm ... :-) Sorry for the confusion!!!

Don't worry, sometimes I have this pitfalls after merges too :-)

I'll push it to npmjs with a new minor version 1.2 ...

Thanks! :-D

maugenst commented 4 years ago

Jesus ... Thanks to the npm guys writing so damn good documentation ... :-( I accidentally passed you the ownership as I tried to add you as a collaborator to this project ... Could you please be so kind to pass it back to me? I'm not able to publish any changes... Sorry for this ...

npm owner add maugenst tabletojson

piranna commented 4 years ago

Done. Yeah, documentation is a bit scarce...

piranna commented 4 years ago

Oh, and thank you for putting me as collaborator :-)