Fixes & clean-ups - Githubissues

maugenst / tabletojson

An npm module for node.js to convert HTML tables to JSON objects

https://www.npmjs.com/package/tabletojson

MIT License

138 stars 38 forks source link

Fixes & clean-ups #51

Closed piranna closed 4 years ago

piranna commented 4 years ago

With Node.js 10 tests are now passing, but with latests version is still spinning. It happens the same in my laptop.

maugenst commented 4 years ago

The problem with the local spawned mock server is that it does not terminate on node 13 ... So I'm currently searching for alternatives as this doesn't work out also on my local node13... I didn't expect since it succeeded on node12. Sorry, my fault. :-(

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 79

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 76:	0.0%
Covered Lines:	112
Relevant Lines:	112

💛 - Coveralls

piranna commented 4 years ago

The problem with the local spawned mock server is that it does not terminate on node 13 ... So I'm currently searching for alternatives as this doesn't work out also on my local node13... I didn't expect since it succeeded on node12. Sorry, my fault. :-(

What about using nock?

maugenst commented 4 years ago

The problem with the local spawned mock server is that it does not terminate on node 13 ... So I'm currently searching for alternatives as this doesn't work out also on my local node13... I didn't expect since it succeeded on node12. Sorry, my fault. :-(

What about using nock?

Looks very promising but still the runtime is not returning. It seems to be a general issue:

piranna commented 4 years ago

Thank you :-)