Fix Offset Calculation in Tables with Complex Rowspans

maugenst / tabletojson

An npm module for node.js to convert HTML tables to JSON objects

https://www.npmjs.com/package/tabletojson

MIT License

138 stars 38 forks source link

Fix Offset Calculation in Tables with Complex Rowspans #88

Closed dooho-h closed 8 months ago

dooho-h commented 8 months ago

Hi!

I've found an issue related to offset calculation in tables that utilize complex rowspans. The offset-adjusted index was consistently computed to be smaller by 1. This discrepancy led to a mismatch between cells and their corresponding columns. I added a test case that demonstrates the previously incorrect behavior.

Besides, I slightly changed the type definitions related to offset calculation. I think its is better for type safety and developer guidance.

maugenst commented 8 months ago

Like your enhancement! Thanks for this