search

mauimauer / cheapcast

It's CheapCast.
Apache License 2.0
399 stars 107 forks source link

Untested fix to allow Ethernet connectivity #29

Closed LawnGnome closed 10 years ago

LawnGnome commented 10 years ago

At present, CheapCast only works if the Android device is using wi-fi for its network connectivity. This means that CheapCast can't be used on devices such as an Ouya if they're plugged into an Ethernet connection.

This PR theoretically fixes this. Unfortunately, I can't figure out how to compile CheapCast to actually test it, but I've tried the heuristic in the PR in a standalone app and it seems to detect the right address on both my phone and my Ouya. (It probably won't work properly on the ATV1200 I have floating around, since that has both Ethernet and wi-fi active at once, but one problem at a time.)

This may require some massaging before it's releasable, but the approach is sound. This would fix issue #8.

mauimauer commented 10 years ago

I'll test this ASAP

lanrat commented 10 years ago

I believe this is the same issue preventing cheapcast from working on some of the Google TVs. Cheapcast works fine on my Logitech Revue when on WIFI, but it is undiscoverable on ethernet .

kaazvaag commented 10 years ago

Does the ethernet fix work? And is it implemented in the new beta?

LawnGnome commented 10 years ago

I've now been able to build this and test it, and it does seem to work fine on both my Ouya (with a wired connection) and my phone (on wifi).

mauimauer commented 10 years ago

Going to release a new version to the store today

lanrat commented 10 years ago

This fixed the issue with using Ethernet on the Revue!

kaazvaag commented 10 years ago

Nice fix. It works on the Minix X5.

clercqer commented 10 years ago

Cheapcast still does not work when I connect my MK809III to my LAN through an USB-to-ethernet adapter. I checked the URLbase and it reports the correct IP.

Can someone help me solve the issue?