search

maulikhirani / scannerX

ScannerX is a showcase app for demonstrating QR/Barcode scanning with CameraX and scanner libraries.
148 stars 33 forks source link

Zxing Scanner Not working not scanning anything #2

Open blazingdevil44 opened 3 years ago

blazingdevil44 commented 3 years ago

ml kit is working perfectly but zxing is not working at all

maulikhirani commented 3 years ago

@blazingdevil44 , can you please share few details like Phone Manufacturer, Model and Android Version on which you're facing the issue? Also it'd be helpful if you can provide sample QR/barcode which is not able to be scanned by ZXing.

blazingdevil44 commented 3 years ago

HUAWEI Y7 Prime 2019 Model:- DUB-LX! Andriod Version 8.1

i downloaded the code you provided in github and didnt make changes since i wanted to see it work first since some codes in github wont work properly and ran it on my device ML kit is working fine but zxing doesn't P.S : i think something missing in your zxing code might be missing not be only my device that having problem not sure though the reason anyway thanks for your quick reply

i really like how you combined zxing with cameraX so i hope its fixed soon

Also i have a question relating zxing lib you used zxing:core:3.4.1 as far as i read in zxing documentation latest version of zxing only works with api 24 and onwards

yet you have put min api as 21 so my question is will your code work for 21 - 23 api ?

maulikhirani commented 3 years ago

Thanks @blazingdevil44 for the details.

You are right, Zxing libray v3.4.x don't support lower API versions of Android. It would just crash when you scan a QR code. To fix that, we can enable Java 8 library desugaring to provide backwards compatibility upto API 21.

I have fixed that issue with ScannerX 1.3 release. (https://github.com/maulikhirani/scannerX/releases/tag/scanner1.3)

You should give it a try with the latest code and let me know the results.

blazingdevil44 commented 3 years ago

awesome what quick update i'll try it later tonight also if possible can you provide and example for fragment as well because mostly on some mobiles fragments give many problems mainly i want to add scanner to fragment and open it in new activity to show result and come back to scanner fragment on backpress

Sorry for late reply mostly update is very slow so i didn't even think it would be updated so soon awesome and thanks again

maulikhirani commented 3 years ago

Hi @blazingdevil44 , I've made some changes that'd probably fix the issue of scanning from Zxing.

Please refer the release notes of ScannerX 1.4

Give it a try and let me know if it works for you!