Fixed IndexError & NameError

maum-ai / faceshifter

Unofficial PyTorch Implementation for FaceShifter (https://arxiv.org/abs/1912.13457)

BSD 3-Clause "New" or "Revised" License

610 stars 114 forks source link

Fixed IndexError & NameError #23

Closed M00-M00 closed 3 years ago

M00-M00 commented 3 years ago

Line:43 changed if len(dets) < 0: to if len(dets) <= 0: as previously if no face is detected it would not be "caught" in if part. This used to result in IndexError

Line:52-126 - moved lines inside else fixing an NameError and excluding images with dets less than 1

usingcolor commented 3 years ago

lgtm. Are you the same person as Ewan?

M00-M00 commented 3 years ago

Hi, yes I am sorry, I just used my work github originally so I changed that. Thanks

On Wed, 21 Jul 2021 at 07:03, Changho Choi 최창호 @.***> wrote:

lgtm. Are you the same person as Ewan?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mindslab-ai/faceshifter/pull/23#issuecomment-883916051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRUZE3KFP357ICAYOOLUYLTYZPMXANCNFSM5AVUD43A .