maunium / dontasktoask.com

An informational website about why you should ask questions directly instead of asking to ask
https://dontasktoask.com
MIT License
432 stars 97 forks source link

Redo Simplified Chinese translation #108

Closed stevenlele closed 1 year ago

stevenlele commented 2 years ago

CC @Cyanoxygen

Cyanoxygen commented 2 years ago

Glad to see someone improving this translation!

For the preferred font, it's better not to use bare sans-serif here - it will look bad when viewing from a non-Chinese version of Windows, as Simplified Chinese variant font usually doesn't take precedence over traditional or Japanese font (the example below is what Zhihu does):

font-family: -apple-system, BlinkMacSystemFont, "Helvetica Neue", "PingFang SC", "Microsoft YaHei", "Source Han Sans SC", "Noto Sans CJK SC", "WenQuanYi Micro Hei", sans-serif;
stevenlele commented 2 years ago

as Simplified Chinese variant font usually doesn't take precedence over traditional or Japanese font

Isn't setting <html lang="zh-Hans"> sufficient? I think modern browsers should be able to handle font family correctly.

Cyanoxygen commented 2 years ago

The answer is yes, but it is better to get font family properly set, for the last resort.

Anyway I will approve this PR, for your better translation. Thanks! :-)