search

maunium / dontasktoask.com

An informational website about why you should ask questions directly instead of asking to ask
https://dontasktoask.com
MIT License
418 stars 94 forks source link

Consider adding CODEOWNERS #71

Closed revi closed 2 years ago

revi commented 2 years ago

I'd like to review changes to Korean translations (ie. #69 ) but I don't want to get notified for every PR which is probably not something I can even read.

So... Can we add CODEOWNERS as an opt-in basis so I (or those who also want to review changes made to the repo) can get review notification when someone opens a PR against languages directory? (Well it might send review for non-translation PRs but I think those who opt in to this can live with that).

revi commented 2 years ago

Ouch,

The people you choose as code owners must have write permissions for the repository.

Nevermind in this case. >_> I guess I'll figure out some way to monitor the repo without receiving all the repo emails.

tulir commented 2 years ago

Giving write access to the repo might be fine, I think I can just protect the master branch to prevent pushing directly

revi commented 2 years ago

Well in that case -- if you feel like it reopen it, and I can probably write a quick PR to add the file tomorrow.