search

maunium / stickerpicker

A fast and simple Matrix sticker picker widget
GNU Affero General Public License v3.0
314 stars 594 forks source link

Implement stickers searching #25

Closed salixor closed 2 years ago

salixor commented 3 years ago

Hey there ! Thanks a lot for this sticker picker.

I like it, but found that a search functionality was really lacking. So this PR should also close #3 !

I implemented the search on both ID and body instead of only body ; I found it may be useful for some packs.

PS : I had to un-minify the CSS for readability (see first commit). Let me know if you wish for me to minify it back !

And here are some previews with the different themes :)

image image image

reivilibre commented 3 years ago

Not the project maintainer, but I noticed: I think the source for the CSS is from this Sass file: https://github.com/maunium/stickerpicker/blob/master/web/style/index.sass

The CSS you unminified is compiled/generated from that Sass file!!

If you made any changes, I think you'll need to put them in the Sass file and recompile it.

To recompile, I think you can run npm run sass or yarn run sass, looking at the package.json file 'scripts' entry.

Luckily it looks like you split up your commit doing the unminification so you can see all the changes you effectively made here https://github.com/maunium/stickerpicker/pull/25/commits/add27513fe3e5383bbc98cd64d694e05ff38ce40#diff-4a74319472588e6885afc9cd35a95f1edd4d77970f829bbf091a48d31d4c60a0 ?

salixor commented 3 years ago

@reivilibre Thanks for the heads up ! Don't know how I managed to miss this (I don't use sass too often, that's probably why).

This has now been fixed ! The split commit was exactly for that reason : to properly track the changes.

Trendyne commented 3 years ago

Small suggestion if this gets picked up again. When the search bar is non-empty, turn the magnifying glass into an X that when clicked clears the text. Should be easy. I merged this PR into my local copy and it works great. Thanks.