Make `run_rule` iterative instead of recursive - Githubissues

maurer / holmes

Datalog engine with extensions for integrating analyses

MIT License

38 stars 4 forks source link

Make `run_rule` iterative instead of recursive #15

Closed maurer closed 7 years ago

maurer commented 7 years ago

run_rule currently recurses on itself any time there's a new rule which could need to trigger from the generated facts. This works, but:

It will result in excess retriggering of rules.
In the event that data gets large, it could overflow the stack.

If run_rule/new_fact's recursion is fixed to use a workset, it could easily lead to perf/scalability improvements.